Add BAZEL_BUILD_DIRECTORY option #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is often useful to limit the Docker build context to a specific directory to reduce the number of files sent to the daemon and speed up builds. Add a BAZEL_BUILD_DIRECTORY option to specify the directory to build the Docker image in, which does not have to be identical to the workspace root.
|
@mishas Can you help review this change ? I had a few more changes that i was interested in pushing upstream. |
mishas
reviewed
Feb 21, 2023
| @@ -121,6 +123,7 @@ def from_config(cls): | |||
| dockerfile=config.get("DAZEL_DOCKERFILE", DEFAULT_LOCAL_DOCKERFILE), | |||
| repository=config.get("DAZEL_REPOSITORY", DEFAULT_REMOTE_REPOSITORY), | |||
| directory=config.get("DAZEL_DIRECTORY", DEFAULT_DIRECTORY), | |||
| build_directory=config.get("DAZEL_BUILD_DIRECTORY", DEFAULT_BUILD_DIRECTORY), | |||
There was a problem hiding this comment.
To make this backwards compatible, can you please make build_directory fallback to directory rather than than to the default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is often useful to limit the Docker build context to a specific directory to reduce the number of files sent to the daemon and speed up builds.
Add a BAZEL_BUILD_DIRECTORY option to specify the directory to build the Docker image in, which does not have to be identical to the workspace root.